-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use application tenant domain to retrieve client app #2557
Use application tenant domain to retrieve client app #2557
Conversation
d97c5b5
to
4e56039
Compare
PR builder started |
PR builder completed |
f51c33a
to
87dc56a
Compare
PR builder started |
PR builder completed |
5a92755
to
1b2aa8c
Compare
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10523947074
tenantDomain); | ||
omitUsernameInIntrospectionRespForAppTokens = oAuthApp.isOmitUsernameInIntrospectionRespForAppTokens(); | ||
|
||
return Boolean.TRUE.equals(oAuthAppDO.isOmitUsernameInIntrospectionRespForAppTokens()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cant we just return the oAuthAppDO.isOmitUsernameInIntrospectionRespForAppTokens()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can. But to be safe used this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oAuthAppDO.isOmitUsernameInIntrospectionRespForAppTokens() never be null right? then its ok
Proposed changes in this pull request
When retrieving an application, use the tenant domain specified in the access token, instead of the user's tenant domain.